Attention is currently required from: Abhijeet Rao, Sonam Sanju, Sridhar Siricilla, Deepti Deshatty.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60000 )
Change subject: soc/intel/alderlake:[TEST] Enable PMC trace
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60000/comment/6ecddcf4_2f9d53fa
PS1, Line 9: production
: systems
Why not?
https://review.coreboot.org/c/coreboot/+/60000/comment/99759172_afbe1f98
PS1, Line 9: It shouldn't be enabled on production
: systems
Please add a dot/period at the end of sentences.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60000
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4d5189683202dd5e31ad21deb5c1cbc4581c478
Gerrit-Change-Number: 60000
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Abhijeet Rao
abhijeet.rao@intel.corp-partner.google.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Reviewer: Sonam Sanju
sonam.sanju@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Abhijeet Rao
abhijeet.rao@intel.corp-partner.google.com
Gerrit-Attention: Sonam Sanju
sonam.sanju@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Comment-Date: Thu, 09 Dec 2021 11:54:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment