Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35614 )
Change subject: gma skl: Implement CDClk switching
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/35614/6/common/hw-gfx-gma-registe...
File common/hw-gfx-gma-registers.ads:
https://review.coreboot.org/c/libgfxinit/+/35614/6/common/hw-gfx-gma-registe...
PS6, Line 1464: DFSM => 16#05_1000# / Register_Width,
Does order matter here? Looks like this offset should go a bit lower.
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/35614
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: Ic14cf5981540d36d3f337a43bbec3574be0d3c99
Gerrit-Change-Number: 35614
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Oct 2019 21:15:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment