Attention is currently required from: Eric Lai, Felix Singer, Nick Vaccaro, Paul Menzel.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79888?usp=email )
Change subject: mb/google/brox: Enable WLAN on root port 5
......................................................................
Patch Set 16:
(1 comment)
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79888/comment/ebc9c3ea_90fe1963 :
PS12, Line 185: PCIe 5 using clk 1
Quite duplicated, isn't it? Please don't document the devicetree in comments.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79888?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I361bef13ebd073b6fccb729a1960d3832cf2681a
Gerrit-Change-Number: 79888
Gerrit-PatchSet: 16
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Mon, 22 Jan 2024 17:47:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-MessageType: comment