Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49050 )
Change subject: drivers/vpd: Add support to read device serial from VPD
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49050/2/src/drivers/vpd/vpd.c
File src/drivers/vpd/vpd.c:
https://review.coreboot.org/c/coreboot/+/49050/2/src/drivers/vpd/vpd.c@301
PS2, Line 301: #if CONFIG(SMBIOS_SERIAL_FROM_VPD)
Does the code need to be in this compilation unit? If not, the guard could
be placed in the Makefile.inc proper.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49050
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14ae07cd8b764e1e22d58577c7cc697ca1496bd5
Gerrit-Change-Number: 49050
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 Jan 2021 22:03:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment