[coreboot-gerrit] [S] Change in coreboot[master]: mb/getac/p470: Use 'enum cb_err'

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68374 )

Change subject: mb/getac/p470: Use 'enum cb_err'
......................................................................

mb/getac/p470: Use 'enum cb_err'

Change-Id: I9650fc672a94343472b44037f8a664d7d15aaf15
Signed-off-by: Elyes Haouas 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68374
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Patrick Georgi 
---
M src/mainboard/getac/p470/ec_oem.c
M src/mainboard/getac/p470/ec_oem.h
2 files changed, 26 insertions(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve

diff --git a/src/mainboard/getac/p470/ec_oem.c b/src/mainboard/getac/p470/ec_oem.c
index 26767d9..c810953 100644
--- a/src/mainboard/getac/p470/ec_oem.c
+++ b/src/mainboard/getac/p470/ec_oem.c
@@ -4,9 +4,11 @@
 #include <arch/io.h>
 #include <delay.h>
 #include <ec/acpi/ec.h>
+#include <types.h>
+
 #include "ec_oem.h"

-int send_ec_oem_command(u8 command)
+enum cb_err send_ec_oem_command(u8 command)
 {
    int timeout;

@@ -19,14 +21,14 @@
    if (!timeout) {
    	printk(BIOS_DEBUG, "Timeout while sending OEM command 0x%02x to EC!\n",
    			command);
-		// return -1;
+		// return CB_ERR;
    }

outb(command, EC_OEM_SC);
-	return 0;
+	return CB_SUCCESS;
 }

-int send_ec_oem_data(u8 data)
+enum cb_err send_ec_oem_data(u8 data)
 {
    int timeout;

@@ -39,12 +41,12 @@
    if (!timeout) {
    	printk(BIOS_DEBUG, "Timeout while sending OEM data 0x%02x to EC!\n",
    			data);
-		// return -1;
+		// return CB_ERR;
    }

outb(data, EC_OEM_DATA);

-	return 0;
+	return CB_SUCCESS;
 }

u8 recv_ec_oem_data(void)
diff --git a/src/mainboard/getac/p470/ec_oem.h b/src/mainboard/getac/p470/ec_oem.h
index 9200f0e..5b5bbcd 100644
--- a/src/mainboard/getac/p470/ec_oem.h
+++ b/src/mainboard/getac/p470/ec_oem.h
@@ -3,6 +3,8 @@
 #ifndef _MAINBOARD_EC_OEM_H
 #define _MAINBOARD_EC_OEM_H

+#include <types.h>
+
 #define EC_OEM_DATA	0x68
 #define EC_OEM_SC	0x6c

@@ -21,8 +23,8 @@
 #define   BD_EC	0x83 // Burst Disable Embedded Controller
 #define   QR_EC	0x84 // Query Embedded Controller

-int send_ec_oem_command(u8 command);
-int send_ec_oem_data(u8 data);
+enum cb_err send_ec_oem_command(u8 command);
+enum cb_err send_ec_oem_data(u8 data);
 u8 recv_ec_oem_data(void);
 u8 ec_oem_read(u8 addr);