Jenrus (Джэнрус) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38143 )
Change subject: ASUS P5Q support and menu entries added ......................................................................
Patch Set 1:
(4 comments)
Patch Set 1:
(5 comments)
Hi, welcome to coreboot!
I've got a few suggestions for you. If you have any questions, feel free to ask me anything :-)
TL:DR; Looks like I need to fix these errors & commit it again ¯_(ツ)_/¯ (excuse me if any kind of emoji is prohibited here)
https://review.coreboot.org/c/coreboot/+/38143/1//COMMIT_MSG Commit Message:
PS1:
… and document that *also* in `Documentation/`.
Hi, thanks for constructive criticism! As much as I use it, the only things tested so far are: -RAM (I using all 4 slots and I have all my 8Gb) -SATA (My two HDDs works fine) -Peripherals (There is no integrated graphics so I use 750Ti) -Audio (at least headphones output and mic input) -USB (My mouse, pen drives & Wi-Fi adapter works) -PS/2 (My good old keyboard works too) What is not tested: -S/PDIF & CD audio in -LAN -IEEE1394 (aka FireWire) -IDE & Floppy -TPM (AFAIK it's not working for sure)
About writing docs, could anyone link me some well-written one as a reference?
https://review.coreboot.org/c/coreboot/+/38143/1//COMMIT_MSG@7 PS1, Line 7: ASUS P5Q support and menu entries added
Commit messages should use imperative tense, as well as the scope of the change as a prefix. […]
Guess I need to recommit my "work" :)
https://review.coreboot.org/c/coreboot/+/38143/1//COMMIT_MSG@10 PS1, Line 10:
There's no `Signed-off` line, which is probably why Jenkins marked the change as failed.
I haven't any exp w/ with Gerrit & Jenkins, so I guess it's only my fault
https://review.coreboot.org/c/coreboot/+/38143/1/src/mainboard/asus/p5qc/var... File src/mainboard/asus/p5qc/variants/p5q/devicetree.cb:
PS1:
This looks very similar to the existing devicetrees. […]
I copypasted the device tree from "p5qc/" variant for any possible future work but guess they right about good intetions & hell