Attention is currently required from: Paul Menzel, chris wang, Felix Held. Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48734 )
Change subject: mb/google/zork: add edp tunning parameter to fix the edp noise ......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48734/comment/cf20de1e_b47b663d PS5, Line 30: register "edp_table_size" = "0x05"
I would think this would be the resulting size of dptuning[] table that gets initialized in FSP. […]
After talking to Eddie and looking at VBIOS spec it does appear that 5 is correct. This is the size of the dptuning[] resulting table passed to VBIOS in bytes counting only valid entries. However this number can not be anything but 5 here since we will always have one table entry filled from edp_tuningset structure fields below. Should we even pass it between CB and FSP? It maybe a good thing to have in case we ever decide to fill in more than one entry but even then it would probably be better to keep it as a count of settings (n) here and then do n * sizeof(edp_tuningset) math for table_size in FSP.