Hello Nico Huber, Patrick Georgi, Martin Roth, Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/libgfxinit/+/43563
to look at the new patch set (#2).
Change subject: Move `PSR_Off` out of `Power_And_Clocks_Haswell` ......................................................................
Move `PSR_Off` out of `Power_And_Clocks_Haswell`
Allowing other platforms to use the Haswell-specific power and clocks package precludes with'ing other Haswell-specific units unless they are placed under `haswell_shared` as well. This unnecessarily forces several implementation-specific details to be public, breaking encapsulation.
The only benefit is that the `PSR_Off` procedure gets to be shared. However, we can allow reusing said procedure without having to destroy encapsulation, by moving it elsewhere. As the SRD/PSR registers are tied to transcoders, place `PSR_Off` and the corresponding definitions to the common `Transcoder` package. Also update the callers of this procedure to refer to the `Transcoder` package, and then drop the visibility of the power and clocks package for Haswell.
Change-Id: I7483409b8b7db58874cbba3c0a7edb1968bba456 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M common/broxton/hw-gfx-gma-power_and_clocks.adb M common/haswell/Makefile.inc R common/haswell/hw-gfx-gma-power_and_clocks_haswell.adb R common/haswell/hw-gfx-gma-power_and_clocks_haswell.ads M common/haswell_shared/Makefile.inc M common/hw-gfx-gma-transcoder.adb M common/hw-gfx-gma-transcoder.ads M common/skylake/hw-gfx-gma-power_and_clocks_skylake.adb 8 files changed, 66 insertions(+), 63 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/63/43563/2