Attention is currently required from: Dinesh Gehlot, Nick Vaccaro, Paul Menzel, Subrata Banik, Wisley Chen.
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81971?usp=email )
Change subject: mb/google/nissa/var/yaviks: Add stop pin for G2 touchscreen
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/yaviks/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/81971/comment/bf9c04cf_bd506217 :
PS2, Line 296: register "generic.stop_delay_ms" = "55"
: register "generic.stop_off_delay_ms" = "5"
The values are fine tuned based on measured timing to meet panel spec.
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81971?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7e0bbc7722cdda6bcca0485009fcf8510b1f55e2
Gerrit-Change-Number: 81971
Gerrit-PatchSet: 2
Gerrit-Owner: Chen Wisley
wisley.chen%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 24 Apr 2024 08:22:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-MessageType: comment