build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30414 )
Change subject: mainboard/facebook/fbg1701: Do initial mainboard commit ......................................................................
Patch Set 16:
(3 comments)
https://review.coreboot.org/#/c/30414/16/src/mainboard/facebook/fbg1701/irqr... File src/mainboard/facebook/fbg1701/irqroute.h:
https://review.coreboot.org/#/c/30414/16/src/mainboard/facebook/fbg1701/irqr... PS16, Line 40: #define PCI_DEV_PIRQ_ROUTES \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/30414/16/src/mainboard/facebook/fbg1701/irqr... PS16, Line 62: #define PIRQ_PIC_ROUTES \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/30414/16/src/soc/intel/braswell/include/soc/... File src/soc/intel/braswell/include/soc/irq.h:
https://review.coreboot.org/#/c/30414/16/src/soc/intel/braswell/include/soc/... PS16, Line 211: ((PIRQ ## b_) << 4) | ((PIRQ ## a_) << 0) code indent should use tabs where possible