[coreboot-gerrit] [M] Change in coreboot[main]: soc/amd/phoenix/pci_irq_routing.c: Populate PCI IRQ routing table

[Felix Held (Code Review)]

Attention is currently required from: Fred Reitberger, Jason Glenesk, Marshall Dawson, Matt DeVillier, Nick Kochlowski.

Felix Held has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/85195?usp=email )

Change subject: soc/amd/phoenix/pci_irq_routing.c: Populate PCI IRQ routing table
......................................................................

Patch Set 6: Code-Review+1

(1 comment)

File src/soc/amd/phoenix/pci_irq_routing.c:

https://review.coreboot.org/c/coreboot/+/85195/comment/8d28cb84_2aa1aac0?usp... :
PS6, Line 18: reserved
the reserved fields don't need to be named; see for example some of the bitfield structs in src/soc/amd/phoenix/include/soc/data_fabric.h. same below. jenkins will complain about those a bit, but that's mainly due to it being a rather uncommon thing and jenkins not knowing that construct, so i've just ignored jenkins' comments on those