Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34005 )
Change subject: drivers/intel: Move FSP stage_cache implementation into common block ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34005/3/src/soc/intel/common/block/... File src/soc/intel/common/block/smm/smm.c:
https://review.coreboot.org/c/coreboot/+/34005/3/src/soc/intel/common/block/... PS3, Line 28: !CONFIG(PLATFORM_USES_FSP1_1) Is this guard really required? Can we get rid of stage_cache_external_region() from drivers/intel/fsp1_1/ too?