Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/22770
Change subject: soc/intel/apollolake: Remove set_subsystem() from SoC ......................................................................
soc/intel/apollolake: Remove set_subsystem() from SoC
Intel common PCI driver is handle PCI subsystem ID programming, hence no need to have an explicit soc function to do the same.
TEST=PCI subsystem id is getting programming during pci enumeration.
Change-Id: I3eb362ff1f3f6d5c81a0dbe854d8ecd59d5a0453 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/apollolake/chip.c 1 file changed, 0 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/22770/1
diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index 1e78cb1..53ffdb9 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -117,20 +117,6 @@ return NULL; }
-static void pci_set_subsystem(device_t dev, unsigned vendor, unsigned device) -{ - if (!vendor || !device) - pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, - pci_read_config32(dev, PCI_VENDOR_ID)); - else - pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, - (device << 16) | vendor); -} - -struct pci_operations soc_pci_ops = { - .set_subsystem = &pci_set_subsystem -}; - static void pci_domain_set_resources(device_t dev) { assign_resources(dev->link_list);