Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43890 )
Change subject: mb/purism/librem_skl: Relocate devicetree FSP settings ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43890/2/src/mainboard/purism/librem... File src/mainboard/purism/librem_skl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43890/2/src/mainboard/purism/librem... PS2, Line 160: # FIXME: corresponding device entry is missing
so? coreboot doesn't do anything with it
If so, then I can drop the FIXME and replace it with `device pci 04.0 on end` when we drop "Device4Enable"
https://review.coreboot.org/c/coreboot/+/43890/2/src/mainboard/purism/librem... PS2, Line 168: # FIXME: does not match devicetree!
this is necessary in order to have the ME status registers printed in cbmem
The enabled PCI device or the "HeciEnabled" value? If the former, we can check if HeciEnabled = 1 makes any difference.
https://review.coreboot.org/c/coreboot/+/43890/2/src/mainboard/purism/librem... PS2, Line 169: register "HeciEnabled" = "0"
not sure this has any effect when ME disabled via HAP
Probably not, and the PCI device should be hidden then. Would be good to test because most boards have these conflicting settings (device pci is on, HeciEnabled = 0)
https://review.coreboot.org/c/coreboot/+/43890/2/src/mainboard/purism/librem... PS2, Line 195: # FIXME: This seems specific to Librem 15
it's not, WiFi is attached to RP5 on all librem_skl variants
So... if only librem 15 enables 1c.4 in devicetree, how does librem 13 work?