26 Aug
2019
26 Aug
'19
8:58 p.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35028 )
Change subject: superio/nuvoton/nct5539d: Add nuvoton NCT5539D specific superio.asl ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35028/7/src/superio/nuvoton/nct5539... File src/superio/nuvoton/nct5539d/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/35028/7/src/superio/nuvoton/nct5539... PS7, Line 167: #define PNP_DEVICE_ACTIVE ACT3 this is for one specific GPIO bank, right? is this intended?
--
To view, visit https://review.coreboot.org/c/coreboot/+/35028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8d64e8faa74802ab0213d87881e57d4d9bd1c35
Gerrit-Change-Number: 35028
Gerrit-PatchSet: 7
Gerrit-Owner: Pavel Sayekat
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Pavel Sayekat
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 26 Aug 2019 20:58:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment