Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32771 )
Change subject: post_code: add post code for critical CBFS failures ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32771/3/src/soc/intel/quark/romstage/fsp2_0.... File src/soc/intel/quark/romstage/fsp2_0.c:
https://review.coreboot.org/#/c/32771/3/src/soc/intel/quark/romstage/fsp2_0.... PS3, Line 120: die_with_post_code(POST_INVALID_CBFS,
That's not clear from the commit message. […]
I think this gets back to the question I asked on the mailing list of what the expectations from the coreboot community are for companies doing work in the project. It seems like you're asking that improvements done in one place be done everywhere. While that's a great goal, I don't think that's really been expected or required up to this point. Let's discuss this in the next leadership meeting along with the other topics of what's expected from a company working in the coreboot project.
We've got 620 instances of 'die(', so it's a lot to expect someone to go through and upgrade them all, or even to figure out what needs to be updated.
Keith, with all that said, could you make this same fix in soc/intel/quark/romstage/fsp1_1.c?