HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45677 )
Change subject: soc/intel: Use ASL 2.0 syntax for GPIO ASL helper function
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45677/1/src/soc/intel/cannonlake/ac...
File src/soc/intel/cannonlake/acpi/gpio_op.asl:
https://review.coreboot.org/c/coreboot/+/45677/1/src/soc/intel/cannonlake/ac...
PS1, Line 100: VAL0 = ~GPIOTXBUFDIS_MASK & VAL0
VAL0 &= ~GPIOTXBUFDIS_MASK
https://review.coreboot.org/c/coreboot/+/45677/1/src/soc/intel/cannonlake/ac...
PS1, Line 102: VAL0 = GPIOTXBUFDIS_MASK | VAL0
VAL0 |= GPIOTXBUFDIS_MASK
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45677
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ebf1f86031eae25337d2dbeabb8893d9f19a14b
Gerrit-Change-Number: 45677
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 24 Sep 2020 11:52:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment