Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40405 )
Change subject: soc/intel/cannonlake: Add support for UARTs on PCH-H ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40405/4/src/soc/intel/cannonlake/pc... File src/soc/intel/cannonlake/pch_h.c:
https://review.coreboot.org/c/coreboot/+/40405/4/src/soc/intel/cannonlake/pc... PS4, Line 3: #include <arch/acpi.h>
fix includes
Ack
https://review.coreboot.org/c/coreboot/+/40405/4/src/soc/intel/cannonlake/pc... PS4, Line 4: arch
acpi/acpigen. […]
Ack
https://review.coreboot.org/c/coreboot/+/40405/4/src/soc/intel/cannonlake/pc... PS4, Line 20: static void pch_h_uart2_fill_ssdt(struct device *dev)
Shouldn't this be const struct device?
Ack