Attention is currently required from: Martin L Roth, Patrick Rudolph, Subrata Banik, Stefan Reinauer, Kapil Porwal, Maximilian Brune, Angel Pons, Lean Sheng Tan.
Hello build bot (Jenkins), Martin L Roth, Patrick Rudolph, Subrata Banik, Kapil Porwal, Stefan Reinauer, Maximilian Brune, Angel Pons, Lean Sheng Tan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74692
to look at the new patch set (#2).
Change subject: Revert "util/ifdtool: Add option to create FMAP template"
......................................................................
Revert "util/ifdtool: Add option to create FMAP template"
This reverts commit 347596ae6ee5ec50526f5dbf9300c183e1d48cd0.
Above commit inserts multiple IFD regions not present into the default
FMAP template, some of which overlap, resulting in far less space
available for BIOS region / CBFS.
Signed-off-by: Matt DeVillier matt.devillier@gmail.com
Change-Id: I7cbcbe16d508787f5c8aae4889199185890f0dc7
---
M Makefile.inc
M util/ifdtool/ifdtool.c
M util/ifdtool/ifdtool.h
3 files changed, 23 insertions(+), 118 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/74692/2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74692
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7cbcbe16d508787f5c8aae4889199185890f0dc7
Gerrit-Change-Number: 74692
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Bill XIE
persmule@hardenedlinux.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-MessageType: newpatchset