Attention is currently required from: Tim Wawrzynczak, Won Chung, Angel Pons, Nick Vaccaro, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61803 )
Change subject: mb/google/var/agah: Use ACPI _PLD macro ......................................................................
Patch Set 2:
(5 comments)
File src/mainboard/google/brya/variants/agah/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/61803/comment/a398a5e5_2a3a62d8 PS2, Line 216: device ref tcss_xhci on
Sure, that would be nicer. Take my Brya P2 as example. There 2 type C in left side and i type A and 1 type C in right side. It better to describe as below:
ACPI_PLD_TYPE_C(RIGHT, LEFT), ACPI_PLD_TYPE_C(RIGHT, RIGHT),
ACPI_PLD_TYPE_A(LEFT, LEFT), ACPI_PLD_TYPE_C(LEFT, RIGHT),
@Eric, marking resolved based on offline discussion?
https://review.coreboot.org/c/coreboot/+/61803/comment/5fffc142_6e2fac07 PS2, Line 262: LEFT
yes, you got my point.
Ack
https://review.coreboot.org/c/coreboot/+/61803/comment/4d4f6e0c_63959670 PS2, Line 269: LEFT
RIGHT
Ack
https://review.coreboot.org/c/coreboot/+/61803/comment/73624cb6_9afe64f9 PS2, Line 283: LEFT
RIGHT
Ack
https://review.coreboot.org/c/coreboot/+/61803/comment/9ba095b7_87b93697 PS2, Line 290: LEFT
RIGHT
Ack