Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47583 )
Change subject: soc/amd/common/block: drop double underscores from include guards
......................................................................
Patch Set 1:
Patch Set 1:
See CB:21073, I have no access to BUG=b:62235990 commentary.
I don't have access to the bug either, but I don't expect much more info in there. Before the patch you referenced some of the include guards had one leading underscore, which they shouldn't have.
I've added the people involved in that patch, so they have a chance to comment on this one and the related ones in the patch train.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47583
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1028fb9097efab8ffae5ffa9fe85a97feebc78a9
Gerrit-Change-Number: 47583
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sat, 14 Nov 2020 21:33:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment