Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36184 )
Change subject: arch/acpi.h: Use of typedef for acpi_vfct_image_hdr
......................................................................
Patch Set 1: Code-Review-1
Why? Using struct directly (some times with const) is well established within coreboot. I can point you hundred of instances. I can't remember a single instance (except vendor code) where a structure is made a typedef.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36184
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65581702a60dbd286cb3910c6eeef5f9e1853cf1
Gerrit-Change-Number: 36184
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1002476
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Name of user not set #1002476
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 22 Oct 2019 01:08:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment