[coreboot-gerrit] Change in coreboot[master]: vendorcode/eltan/security/lib: Add missing vb2ex_printf()

[Christian Walter (Code Review)]

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34666 )

Change subject: vendorcode/eltan/security/lib: Add missing vb2ex_printf()
......................................................................

Patch Set 2: -Code-Review
> Patch Set 2:
> > Patch Set 2: Code-Review-1
> >
> > Why do you need that code? And why do you just copy it over? And why do you have to add this into all stages? I can"t see this print get used anywhere.
>
> Function vb2_rsa_verify_digest (file 3rdparty/vboot/firmware/2lib/include/2rsa.c) calls VB2_DEBUG. This VB2_DEBUG is defined as vb2ex_printf. 
> Did a retry and noticed that this function is required for bootblock stage only.

Okay - then you might want to remove it form the other stages. Can't you use the function which is already in coreboot for this? I guess because you are doing your own implementation of VBOOT this might be a bit tricky.