Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83626?usp=email )
Change subject: mb/starlabs/starbook/rpl: Nit GPIO changes ......................................................................
mb/starlabs/starbook/rpl: Nit GPIO changes
Remove some unused GPIOs and configurations for GPIO's that aren't even connected.
Change-Id: I5b4691a0b5e8b1348304d11c1d59aa60517041ec Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/83626 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/starlabs/starbook/variants/rpl/gpio.c 1 file changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index e1ff928..bf6404e 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -274,11 +274,11 @@ /* E16: Not Connected */ PAD_NC(GPP_E16, NONE), /* E17: Not Connected */ - PAD_CFG_GPO(GPP_E17, 1, PLTRST), + PAD_NC(GPP_E17, NONE), /* E18: Thunderbolt LSX TXD */ - PAD_NC(GPP_E18, NATIVE), + PAD_NC(GPP_E18, NONE), /* E19: Thunderbolt LSX RXD */ - PAD_NC(GPP_E19, NATIVE), + PAD_NC(GPP_E19, NONE), /* E20: Not Connected */ PAD_NC(GPP_E20, NONE), /* E21: Not Connected */ @@ -309,11 +309,11 @@ /* F8: Not Connected */ PAD_NC(GPP_F8, NONE), /* F9: EC Sleep S0 */ - PAD_CFG_GPO(GPP_F9, 1, PLTRST), + PAD_NC(GPP_F9, NONE), /* F10: Weak Internal PD 20K */ PAD_CFG_GPO(GPP_F10, 1, PLTRST), /* F11: TPM ID */ - PAD_CFG_GPI_TRIG_OWN(GPP_F11, NONE, DEEP, OFF, ACPI), + PAD_NC(GPP_F11, NONE), /* F12: Not Connected */ PAD_NC(GPP_F12, NONE), /* F13: Not Connected */ @@ -323,7 +323,7 @@ /* F15: Not used Accelerometer Interrupt 2*/ PAD_NC(GPP_F15, NONE), /* F16: Not Connected */ - PAD_CFG_GPO(GPP_F16, 1, RSMRST), + PAD_NC(GPP_F16, NONE), /* F17: Not used Touch Panel Reset */ PAD_NC(GPP_F17, NONE), /* F18: Not used Touch Panel Interrupt */