Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34287 )
Change subject: soc/intel/{cnl,icl}: Always use CAR NEM enhanced by default
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34287/2/src/soc/intel/cannonlake/Kc...
File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/34287/2/src/soc/intel/cannonlake/Kc...
PS2, Line 272: default USE_CANNONLAKE_CAR_NEM_ENHANCED
Unless we make it a policy to always set a default, I would prefer […]
I would recommend bringing the topic up on the mailing list. Once we have a policy w.r.t. explicit defaults on choices, I have no problem with writing a patch uniformizing the defaults on Kconfig choices.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34287
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30b1808f91701c07dce6f1de08c213150e8a675a
Gerrit-Change-Number: 34287
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Fri, 12 Jul 2019 21:37:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment