[coreboot-gerrit] [L] Change in coreboot[main]: soc/mediatek/mt8189: Add a stub implementation of MT8189 SoC

[Yidi Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Vince Liu.

Yidi Lin has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85616?usp=email )

Change subject: soc/mediatek/mt8189: Add a stub implementation of MT8189 SoC
......................................................................

Patch Set 1: Code-Review+1

(3 comments)

File src/soc/mediatek/mt8189/include/soc/memlayout.ld:

https://review.coreboot.org/c/coreboot/+/85616/comment/6e9763fa_2f6cae8a?usp... :
PS1, Line 22: 	/*
            : 	* Since MCUPM uses most of the space, most regions are put in SRAM_L2C below.
            : 	*/
            : 
wrong indent

https://review.coreboot.org/c/coreboot/+/85616/comment/73fbd5ed_15c46c6f?usp... :
PS1, Line 35: 	/*
            : 	* The needed size can be obtained by:
            : 	*  aarch64-cros-linux-gnu-objdump -x dram.elf | grep memsz
            : 	* To move the address, dram.elf also needs to be modified accordingly.
            : 	*/
wrong indent

https://review.coreboot.org/c/coreboot/+/85616/comment/12a61451_ecdf297c?usp... :
PS1, Line 42: 	/*
            : 	* The bootROM needs 4K starting from SRAM_L2C_START so the bootblock starting address
            : 	* is fixed at SRAM_L2C_START + 4K, and the 4K can be reused after bootblock is started.
            : 	* To move the address, gen-bl-img.py also needs to be modified accordingly.
            : 	*/
wrong indent