Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37769 )
Change subject: device/pciexp: Match Max_Payload_Size between ends of a link ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37769/1/src/device/pciexp_device.c File src/device/pciexp_device.c:
https://review.coreboot.org/c/coreboot/+/37769/1/src/device/pciexp_device.c@... PS1, Line 430: /* Set max payload to smaller of the reported device capability. */
Perhaps somewhere comment or print why you're capping the field to 5. […]
Done
https://review.coreboot.org/c/coreboot/+/37769/1/src/device/pciexp_device.c@... PS1, Line 445: endp_devctl |= max_payload << 5; Oh dear :(
https://review.coreboot.org/c/coreboot/+/37769/1/src/device/pciexp_device.c@... PS1, Line 448: PCIe: Max_Payload_Size adjusted to %d
The console output likely makes it obvious what B:D:F this is. […]
I'll see about the consistency of the logging separately.
https://review.coreboot.org/c/coreboot/+/37769/1/src/device/pciexp_device.c@... PS1, Line 482: }
Meh, the spec says you don't need to do this for each function in a multi-function device. […]
That's probably true for all the pciexp_xx() calls we make above. I could consider some followup work on this, if someone has suitable PCIe topology hardware to test on.