[coreboot-gerrit] Change in ...coreboot[master]: vboot: copy data structures to CBMEM for downstream use

[Joel Kitching (Code Review)]

Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31329 )

Change subject: vboot: copy data structures to CBMEM for downstream use
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/31329/3/src/security/vboot/common.c 
File src/security/vboot/common.c:

https://review.coreboot.org/#/c/31329/3/src/security/vboot/common.c@44 
PS3, Line 44: static uint8_t use_cbmem CAR_GLOBAL;
> I thought it was a slightly simpler solution. […]

We could also just simplify and get rid of the global altogether:

struct vb2_working_data *vb2_wd;

if (vb2_wd == NULL && cbmem_possibly_online())
    	vb2_wd = cbmem_find(CBMEM_ID_VBOOT_WORKBUF);

if (vb2_wd == NULL && VBOOT_PRE_RAM_SYMBOLS &&
        pre_ram_symbols_accessible())
    	vb2_wd = (struct vb2_working_data *)_vboot2_work;

assert(vb2_wd != NULL);

return vb2_wd;