Attention is currently required from: Ashish Kumar Mishra, Deepti Deshatty, Eric Herrmann, Karthik Ramasubramanian, Sowmya Aralguppe.
Shelley Chen has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83406?usp=email )
Change subject: mb/google/brox: Reduce PL values for booting without battery
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brox/variants/baseboard/brox/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83406/comment/f6c9ef65_89b58b61?usp... :
PS4, Line 96: * +-------------+-----+------+---------+-------+
: * | Max Power(W)| TDP | PL2 | PsysPL2 | PL3/4 |
: * +-------------+-----+------+---------+-------+
: * | 30 | 15 | 17 | 25 | 25 | <--- not working yet
: * | 45 | 15 | 26 | 38 | 38 |
: * | 60 | 15 | 35 | 51 | 51 |
: * | 110 | 15 | 55 | 94 | 96 |
: * +-------------+-----+------+---------+-------+
: */
can you please adjust the table to reflect the updated values below?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83406?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia0074bfc97c54f07d0b7257393de7c355e36b262
Gerrit-Change-Number: 83406
Gerrit-PatchSet: 4
Gerrit-Owner: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Reviewer: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Reviewer: Eric Herrmann
eherrmann@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Attention: Eric Herrmann
eherrmann@google.com
Gerrit-Attention: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 17 Jul 2024 16:54:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No