Attention is currently required from: David Wu, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Kenneth Chan, Nick Vaccaro, Rishika Raj.
Subrata Banik has posted comments on this change by Kenneth Chan. ( https://review.coreboot.org/c/coreboot/+/83878?usp=email )
Change subject: mb/google/brya/var/nova: Set up soundbar-related gpios
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/brya/variants/nova/gpio.c:
https://review.coreboot.org/c/coreboot/+/83878/comment/b337cf18_c8fef8b0?usp... :
PS5, Line 44: PAD_CFG_GPO
Lock the pin still can change the output value.
lock is like locking the pad configuration and not the Tx/Rx. Hence, I would suggest to locking the PIN if you don;t need to reconfigure this PAD after booting to OS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83878?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I49815aa3e3192e98170861c4d168c8136def5ccd
Gerrit-Change-Number: 83878
Gerrit-PatchSet: 5
Gerrit-Owner: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 15 Aug 2024 06:29:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com