Attention is currently required from: Matt DeVillier, Paul Menzel, Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58229 )
Change subject: mb/google/poppy: set SMBIOS enclosure type for all poppy variants
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58229/comment/4ed2ec6f_d1f8570a
PS2, Line 9: Some poppy variants did not select a system type, which led to the default
: desktop type being set. Select the best fit enclosure type for each variant.
: Alphabetize the variants specific options for improved readability/clarity.
Please wrap at 72 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58229
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c23f8fa3ae1de67f7a68b8a4e9ec16c4e8044df
Gerrit-Change-Number: 58229
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Mon, 11 Oct 2021 18:56:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment