[coreboot-gerrit] [M] Change in coreboot[master]: soc/amd: Create AMD common reset code

[Felix Held (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Fred Reitberger.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72658 )

Change subject: soc/amd: Create AMD common reset code
......................................................................

Patch Set 1:

(2 comments)

File src/soc/amd/common/block/reset/reset.c:

PS1: 
since this lives in the acpimmio pm register block, i'd consider moving it to soc/amd/common/block/pm/reset.c. i'd be ok with either option tough

https://review.coreboot.org/c/coreboot/+/72658/comment/d44589fb_8d186aa0 
PS1, Line 22: 	outb(RST_CPU | SYS_RST, RST_CNT);
i'd either put this into the corresponding else branch or add a return after the do_cold_reset call. this wont really change behavior, but would make it easier to understand what will happen there