Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31603 )
Change subject: mainboard: Add ASRock H110M-DVS ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/spd/spd_u... File src/mainboard/asrock/h110m/spd/spd_util.c:
PS2:
Is this needed?
That only Intel can answer as it's undocumented. I'd leave it as it's board specific, but spd_util.c is a bad name. There's no SPD handling in here.
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... File src/mainboard/asrock/h110m/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 243: off Should always be on
https://review.coreboot.org/#/c/31603/2/src/mainboard/asrock/h110m/variants/... PS2, Line 246: off Set to on to enable onboard audio. You might need to configure gpios if not done already.