Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48220 )
Change subject: soc/amd: move smi_util to common block ......................................................................
Patch Set 1:
(2 comments)
Patch Set 1:
Patch Set 1:
smi_util.c from picasso was a 1:1 copy of the stoneyridge code
the mapping of things to the sci number is different in the socs, but i kept that part in the soc/smi.h headers. if you think that i should verify the code also applies to the next generation, i can have a look at it again tomorrow
We need to check the specs anyway, so since it's moving to common it's probably a good time to do it. I think we'll be OK but I want to make sure we use the right amount of caution.
https://review.coreboot.org/c/coreboot/+/48220/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48220/1//COMMIT_MSG@10 PS1, Line 10: doesn't use any functions that are only present when this : option is selected Maybe reword to end one sentence, stating what you're doing.
https://review.coreboot.org/c/coreboot/+/48220/1//COMMIT_MSG@11 PS1, Line 11: so this patch also drops the guards in the : Makefile.inc file. I'd make this a separate sentence, and not beginning with "so".