[coreboot-gerrit] Change in coreboot[master]: arch/x86: Init firmware pointer for EC SMSC KBC1098/KBC1126 at build ...

[Bill XIE (Code Review)]

Attention is currently required from: Arthur Heymans, Nico Huber, Patrick Rudolph, Angel Pons, Julius Werner, Michael Niewöhner, Kyösti Mälkki, Aaron Durbin.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51671 )

Change subject: arch/x86: Init firmware pointer for EC SMSC KBC1098/KBC1126 at build time
......................................................................

Patch Set 29:

(3 comments)

File src/arch/x86/Kconfig:

https://review.coreboot.org/c/coreboot/+/51671/comment/f89e5e28_64f3afc7 
PS27, Line 355: present
> nit: Missing a period

Done

File src/arch/x86/bootblock.ld:

https://review.coreboot.org/c/coreboot/+/51671/comment/9a944e81_9febcc42 
PS27, Line 57: 	_ID_SECTION_END = SIZEOF(.ecfw_ptr) && SIZEOF(.id) > _ID_SECTION_END - _ECFW_PTR ? _ECFW_PTR : _ID_SECTION_END;
> Reposting my CB:51059 comment about this: […]

Done. As Arthur stated in CB:51059, _ID_SECTION_END is fixed at either 0xffffff80 or _X86_RESET_VECTOR, overlapping is left for the linker to detect.

File src/ec/hp/kbc1126/Kconfig:

https://review.coreboot.org/c/coreboot/+/51671/comment/25f3e22c_94b850eb 
PS27, Line 30: if KBC1126_FIRMWARE
> > I'd much prefer to always add the `. […]

Done as Arthur recommended.