Attention is currently required from: Evgeny Zinoviev, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59527 )
Change subject: mb/lenovo: Enable MEI on Sandy Bridge ThinkPads ......................................................................
Patch Set 2: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59527/comment/c8aca44f_df64aee1 PS2, Line 7: Sandy Bridge Strictly speaking, this should be `Cougar Point`, the PCH. It's possible [1] to use Ivy Bridge CPUs on these mainboards.
[1]: Even though it's very complicated, it's possible to replace BGA CPUs.
https://review.coreboot.org/c/coreboot/+/59527/comment/87636916_f19517dc PS2, Line 12: 0793afe9 commit 0793afe9 (mb/lenovo/x220: disable ME)
https://review.coreboot.org/c/coreboot/+/59527/comment/3dcc2342_90462100 PS2, Line 13: today With which Linux kernel version?
https://review.coreboot.org/c/coreboot/+/59527/comment/c72e975c_4fe4ed10 PS2, Line 15: Also: : - it breaks the me_disable feature, : - we already have a Kconfig option to hide MEI in case of errors, : - it will be hidden on disabled, recovery, firmware update paths anyway. I'd convert this list of reasons into a paragraph.