Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47863 )
Change subject: volteer/variants/eldrid: redefine usb2 ports register
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47863/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47863/2//COMMIT_MSG@7
PS2, Line 7: volteer/variants/eldrid: usb2 ports tuning
Please make it a statement by using a verb in imperative mood. […]
Done
https://review.coreboot.org/c/coreboot/+/47863/2/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47863/2/src/mainboard/google/voltee...
PS2, Line 64:
extra tab
Done
https://review.coreboot.org/c/coreboot/+/47863/2/src/mainboard/google/voltee...
PS2, Line 70:
extra tab
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47863
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b8a5c0d5e814de232d79a43354f5ec0220fc5ea
Gerrit-Change-Number: 47863
Gerrit-PatchSet: 3
Gerrit-Owner: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Comment-Date: Tue, 24 Nov 2020 01:58:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment