25 Feb
2021
25 Feb
'21
10:57 a.m.
Attention is currently required from: Julius Werner, Bob Moragues, Wai-Hong Tam. Xuxin Xiong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51004 )
Change subject: mb/google/trogdor: Add new configs homestar ......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/trogdor/board.h:
https://review.coreboot.org/c/coreboot/+/51004/comment/11d52fd1_ea64ea7c PS2, Line 21: ((CONFIG(BOARD_GOOGLE_COACHZ) || CONFIG(BOARD_GOOGLE_HOMESTAR)) ? (board_id() == 0 ? GPIO(52) : \
Yes, like I mentioned the better method is to write it the way I suggested in CL:2705664. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/51004
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0f9b6c89198a882acae7191d08b166eb8c1dd71
Gerrit-Change-Number: 51004
Gerrit-PatchSet: 8
Gerrit-Owner: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues moragues@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Tao Xia xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Wai-Hong Tam waihong@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Shelley Chen shchen@google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Bob Moragues moragues@chromium.org
Gerrit-Attention: Wai-Hong Tam waihong@google.com
Gerrit-Comment-Date: Thu, 25 Feb 2021 10:57:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com
Gerrit-MessageType: comment