Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61088 )
Change subject: soc/amd/sabrina: drop graphics.c ......................................................................
soc/amd/sabrina: drop graphics.c
Since we don't need to support PCI ID remapping for finding the correct VBIOS binary for the integrated GPU, graphics.c can be dropped for now.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ifd5b678f472b3b5888353efd057203eb641be874 Reviewed-on: https://review.coreboot.org/c/coreboot/+/61088 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/sabrina/Makefile.inc D src/soc/amd/sabrina/graphics.c M src/soc/amd/sabrina/include/soc/cpu.h 3 files changed, 0 insertions(+), 27 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/sabrina/Makefile.inc b/src/soc/amd/sabrina/Makefile.inc index 734f152..2beb6de 100644 --- a/src/soc/amd/sabrina/Makefile.inc +++ b/src/soc/amd/sabrina/Makefile.inc @@ -39,7 +39,6 @@ ramstage-y += fch.c ramstage-y += fsp_s_params.c ramstage-y += gpio.c -ramstage-y += graphics.c ramstage-y += i2c.c ramstage-y += mca.c ramstage-y += preload.c diff --git a/src/soc/amd/sabrina/graphics.c b/src/soc/amd/sabrina/graphics.c deleted file mode 100644 index b65ef88..0000000 --- a/src/soc/amd/sabrina/graphics.c +++ /dev/null @@ -1,21 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -/* TODO: Check if this is still correct */ - -#include <device/pci_rom.h> -#include <soc/cpu.h> -#include <stdint.h> - -u32 map_oprom_vendev(u32 vendev) -{ - u32 new_vendev = vendev; - - switch (vendev) { - case CEZANNE_VBIOS_VID_DID: - case BARCELO_VBIOS_VID_DID: - new_vendev = CEZANNE_VBIOS_VID_DID; - break; - } - - return new_vendev; -} diff --git a/src/soc/amd/sabrina/include/soc/cpu.h b/src/soc/amd/sabrina/include/soc/cpu.h index 9aa07b0..b757813 100644 --- a/src/soc/amd/sabrina/include/soc/cpu.h +++ b/src/soc/amd/sabrina/include/soc/cpu.h @@ -1,13 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* TODO: Check if this is still correct */ - #ifndef AMD_SABRINA_CPU_H #define AMD_SABRINA_CPU_H
#define SABRINA_A0_CPUID 0x008a0f00
-#define CEZANNE_VBIOS_VID_DID 0x10021638 -#define BARCELO_VBIOS_VID_DID 0x100215e7 - #endif /* AMD_SABRINA_CPU_H */