John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34145 )
Change subject: src/cpu/intel: Add sanity check for cpu turbo mode capability ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34145/6/src/cpu/intel/turbo/turbo.c File src/cpu/intel/turbo/turbo.c:
https://review.coreboot.org/c/coreboot/+/34145/6/src/cpu/intel/turbo/turbo.c... PS6, Line 57: int get_turbo_state(void)
I am wondering if we should add a function: […]
Done
https://review.coreboot.org/c/coreboot/+/34145/6/src/cpu/intel/turbo/turbo.c... PS6, Line 107: cpuid_regs = cpuid(CPUID_LEAF_PM); : turbo_cap = !!(cpuid_regs.eax & PM_CAP_TURBO_MODE); : : if (!turbo_cap) { : /* Unavailable */ : turbo_state = TURBO_UNAVAILABLE; : printk(BIOS_INFO, "Turbo is unavailable\n"); : } else { : /* Available */ : turbo_state = TURBO_ENABLED; : printk(BIOS_INFO, "Turbo has been enabled\n"); : } : : /* Update cached turbo state */ : set_global_turbo_state(turbo_state);
And then all of this can be changed to: […]
Done
https://review.coreboot.org/c/coreboot/+/34145/6/src/cpu/intel/turbo/turbo.c... PS6, Line 138: TURBO_UNAVAILABLE
Shouldn't this be TURBO_DISABLED?
Done
https://review.coreboot.org/c/coreboot/+/34145/6/src/cpu/intel/turbo/turbo.c... PS6, Line 137: /* Update cached turbo state */ : set_global_turbo_state(TURBO_UNAVAILABLE); : printk(BIOS_INFO, "Turbo has been disabled\n");
And this can be changed to do the same i.e. […]
Done