Attention is currently required from: Angel Pons, Branden Waldner, Christian Walter, Felix Held, Jakub Czapiga, Julius Werner, Keith Hui, Martin L Roth, Patrick Rudolph, Paul Menzel, Raul Rangel, Stefan Reinauer, ron minnich.
Hello Aaron Durbin, Andrey Petrov, Christian Walter, Erik van den Bogaert, Felix Held, Frans Hendriks, Furquan Shaikh, Jakub Czapiga, Jason Glenesk, Julius Werner, Marshall Dawson, Martin L Roth, Michał Żygowski, Patrick Rudolph, Philipp Hug, Piotr Król, Raul Rangel, Stefan Reinauer, Subrata Banik, Yu-Ping Wu, build bot (Jenkins), ron minnich, ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55068?usp=email
to look at the new patch set (#39).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: Allow to build romstage sources inside the bootblock ......................................................................
Allow to build romstage sources inside the bootblock
Having a separate romstage is only desirable: - with advanced setups like vboot or normal/fallback - boot medium is slow at startup (some ARM SOCs) - bootblock is limited in size (Intel APL 32K)
When this is not the case there is no need for the extra complexity that romstage brings. Including the romstage sources inside the bootblock substantially reduces the total code footprint. Often the resulting code is 10-20k smaller.
This is controlled via a Kconfig option.
TESTED: works on qemu x86, arm and aarch64 with and without VBOOT.
Change-Id: Id68390edc1ba228b121cca89b80c64a92553e284 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M Makefile.inc M src/Kconfig M src/arch/arm64/romstage.c M src/arch/x86/Makefile.inc M src/arch/x86/assembly_entry.S M src/arch/x86/car.ld M src/arch/x86/memcpy.c M src/arch/x86/memlayout.ld M src/arch/x86/memmove_32.c M src/arch/x86/memset.c M src/commonlib/storage/sdhci.c M src/console/Kconfig M src/console/console.c M src/console/init.c M src/cpu/x86/cache/cache.c M src/drivers/net/ne2k.c M src/drivers/siemens/nc_fpga/nc_fpga_early.c M src/drivers/usb/ehci_debug.c M src/drivers/vpd/vpd.c M src/include/cbmem.h M src/include/console/cbmem_console.h M src/include/console/console.h M src/include/console/ne2k.h M src/include/console/qemu_debugcon.h M src/include/console/spkmodem.h M src/include/console/system76_ec.h M src/include/console/uart.h M src/include/console/usb.h M src/include/memlayout.h M src/include/rules.h M src/include/symbols.h M src/include/timestamp.h M src/lib/asan.c M src/lib/cbfs.c M src/lib/prog_loaders.c M src/mainboard/emulation/qemu-armv7/romstage.c M src/mainboard/emulation/qemu-riscv/memlayout.ld M src/mainboard/google/butterfly/chromeos.c M src/mainboard/google/daisy/romstage.c M src/mainboard/google/peach_pit/romstage.c M src/mainboard/google/poppy/variants/nautilus/sku.c M src/mainboard/google/rambi/chromeos.c M src/mainboard/google/veyron/romstage.c M src/mainboard/google/veyron_mickey/romstage.c M src/mainboard/google/veyron_rialto/romstage.c M src/mainboard/ti/beaglebone/romstage.c M src/security/tpm/tspi/crtm.c M src/security/tpm/tspi/log-tpm1.c M src/security/tpm/tspi/log-tpm2.c M src/security/tpm/tspi/log.c M src/security/vboot/Kconfig M src/security/vboot/Makefile.inc M src/security/vboot/common.c M src/security/vboot/misc.h M src/security/vboot/vboot_common.c M src/soc/intel/common/block/pmc/pmclib.c M src/soc/intel/common/block/systemagent/memmap.c M src/vendorcode/eltan/security/verified_boot/vboot_check.c M tests/lib/imd_cbmem-test.c 59 files changed, 137 insertions(+), 102 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/55068/39