HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43160 )
Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43160/2/src/southbridge/intel/i8280...
File src/southbridge/intel/i82801gx/acpi/globalnvs.asl:
https://review.coreboot.org/c/coreboot/+/43160/2/src/southbridge/intel/i8280...
PS2, Line 18: Offset (0x00),
Elyes, these are added for alignment purposes (i82801ix/i82801jx have them). […]
I think you can remove redundant and make alignment to a clean file.
Please don't add them ... ( I spent time to remove many of them )
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43160
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad9699709f3e90670f2d4f9b5664a048971ea412
Gerrit-Change-Number: 43160
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 07 Jul 2020 14:37:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment