Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31474 )
Change subject: vboot: standardize on working data size ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31474/2/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/#/c/31474/2/src/security/vboot/Kconfig@95 PS2, Line 95: VBOOT_WORKING_DATA_SIZE
Can we avoid having this Kconfig and simply use VB2_WORKBUF_RECOMMENDED_SIZE directly since it is ex […]
Hi Furquan, This was my original thought, however I realized it's quite difficult since including vb2_api.h also seems to include stuff that messes up the linker. The first problem I encountered was the definition of ALIGN (which needs to be left alone), which I solved by #undef right after the #include. The second one simply caused a syntax error in a .ld file. I believe Julius suggested that one option would be putting the constant we wish to use (VB2_WORKBUF_RECCOMEDED_SIZE) in a separate header file and including that header directly. Would that be a preferable option?