Attention is currently required from: Furquan Shaikh, Martin Roth, Subrata Banik, Angel Pons, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51446 )
Change subject: soc/intel/alderlake: Inject Pre-CPU reset TS into timestamp_table ......................................................................
Patch Set 4:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51446/comment/99e5b8ec_00acdb98 PS4, Line 8: I like timestamps. ;-)
1. Why is this SoC specific? 2. Why is it a Kconfig option and not built in unconditionally?
https://review.coreboot.org/c/coreboot/+/51446/comment/b92efe86_20d2bfc7 PS4, Line 12: Please paste the cbfstool output.
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/51446/comment/c92bed99_380e0456 PS4, Line 278: telemetry. Maybe:
Say yes here, if you would like to capture pre-CPU reset telemetry.
File src/soc/intel/alderlake/telemetry.c:
https://review.coreboot.org/c/coreboot/+/51446/comment/a810f6d5_7d3a1d99 PS4, Line 32: u16 time_stamp_1_ms; Why the different lengths?
https://review.coreboot.org/c/coreboot/+/51446/comment/58e58461_7838c771 PS4, Line 109: printk(BIOS_DEBUG, "ME_BIOS_PAYLOAD_HOB missing!\n"); Sounds like an error to me?