4 Jun
2020
4 Jun
'20
12:16 a.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41793 )
Change subject: drivers/uart/acpi: Add new device driver for UART attached devices ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/41793/1/src/drivers/uart/acpi/acpi.... File src/drivers/uart/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/41793/1/src/drivers/uart/acpi/acpi.... PS1, Line 93: SLP_TYP_S3
I noticed most of these drivers are using a fixed '3' here which isn't going to be correct for AMD.
Did you mean Intel?
--
To view, visit https://review.coreboot.org/c/coreboot/+/41793
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idfd2d9d2ab6990a82ddd401734c0d9b1b0b8f82d
Gerrit-Change-Number: 41793
Gerrit-PatchSet: 3
Gerrit-Owner: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 04 Jun 2020 07:16:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Duncan Laurie dlaurie@chromium.org
Gerrit-MessageType: comment