Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35459 )
Change subject: mb/google/hatch: Remove GPIO_DRIVER from pen eject GPIO configuration
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35459/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/35459/1/src/mainboard/google/hatch/...
PS1, Line 34: LEVEL
It wakes up if the pen is left out of the garage, will fix.
Ah yes, it is marked SCI without invert. It will wake up if left out of garage.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If017e12e23134f5cfed7cbb6047cc9badd9bf7e8
Gerrit-Change-Number: 35459
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 18 Sep 2019 21:20:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment