Attention is currently required from: Julius Werner, Martin L Roth, Nicholas Chin.
Nico Huber has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/84431?usp=email )
Change subject: sconfig: Move config_of_soc from device.h to static.h
......................................................................
Patch Set 2:
(2 comments)
File src/include/device/devicetree.h:
PS1:
It's only referencing an external void pointer. So there's another alternative: […]
Actually, there may be a technical argument: We could even safe us further
`static.h` includes that way, couldn't we?
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/84431/comment/04e3cda1_359ba2e8?usp... :
PS2, Line 1944: walk_device_tree(gen, dev, &base_root_dev, expose_device_names);
Would also work here (closer to the original extern declaration).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84431?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7c40135bf2815093b81e47201c38b7d0a6ac8fa8
Gerrit-Change-Number: 84431
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Sat, 21 Sep 2024 14:58:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com