Attention is currently required from: Nico Huber, Tim Wawrzynczak, Sridhar Siricilla, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59359 )
Change subject: soc/intel/common: Implements ACPI CPPCv3 package to support hybrid core
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/acpi/acpi/globalnvs.asl:
https://review.coreboot.org/c/coreboot/+/59359/comment/c43915ca_7a79989c
PS1, Line 28: SFBC, 16, // 0x48 - 0x49 Indicates Scaling factor for Big core
: SFSC, 16, // 0x50 - 0x51 Indicates Scaling Factor for Small Core
: NMFQ, 16, // 0x52 - 0x53 Indicates Nominal Frequency
: CORE, 32, // 0x54 - 0x57 Each marked bit indicates Big Core corresponding to core index
: INFS, 8, // 0x58 - Nominal Frequency is supported
:
where are these used? do these values have to be in gnvs in contrast to generating and adding them to DSDT?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd5ea9e70bebd1e66d3cea2bcf8a6678e5cc95ca
Gerrit-Change-Number: 59359
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 17 Nov 2021 07:31:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment