Attention is currently required from: Martin L Roth, Jon Murphy.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68644 )
Change subject: util/cbmem: Update formatting for cbmem -l command
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File util/cbmem/cbmem.c:
https://review.coreboot.org/c/coreboot/+/68644/comment/0deb6c93_e08d8685
PS1, Line 1188: name = "UNKNOWN";
nit: since the other names are all in all-caps, I'd maybe make this `(unknown)` to make it stand out more.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68644
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d91d21c6ad418d9fee9880550fb6cb9e41e93f0
Gerrit-Change-Number: 68644
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Comment-Date: Mon, 31 Oct 2022 18:25:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment