Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43661 )
Change subject: mb/google/zork/vilboz: Tune I2C bus 3 clock ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43661/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43661/1//COMMIT_MSG@2 PS1, Line 2: peichao.wang Please use *Peicho Wang*.
https://review.coreboot.org/c/coreboot/+/43661/1//COMMIT_MSG@7 PS1, Line 7: mb/google/zork/vilboz: Tune I2C bus 3 clock Please look at other commits, how this is formulated. (What frequency is the target?)
https://review.coreboot.org/c/coreboot/+/43661/1//COMMIT_MSG@15 PS1, Line 15: Peichao.Wang Please remove the dot between the names.
https://review.coreboot.org/c/coreboot/+/43661/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43661/1/src/mainboard/google/zork/v... PS1, Line 31: .rise_time_ns = 184, /* 0 to 1.26v (1.8 * .7) */ Are the comment incorrect?